This repository was archived by the owner on Oct 24, 2023. It is now read-only.
Category Manager - list and view working; add+edit skeleton#190
Open
sdecianu wants to merge 1 commit intocode4romania:masterfrom
Open
Category Manager - list and view working; add+edit skeleton#190sdecianu wants to merge 1 commit intocode4romania:masterfrom
sdecianu wants to merge 1 commit intocode4romania:masterfrom
Conversation
sdecianu
changed the title
sdecianu
commented
Feb 26, 2022
| export class CategoriesService { | ||
| constructor(private httpClient: HttpClient) {} | ||
|
|
||
| /** |
Author
There was a problem hiding this comment.
There's a bunch of code related to pagination copy-pasted from the Resources components, but they're not used since the RVM categories API doesn't currently support pagination.
I'm still considering whether I should just completely remove them, if we don't intend to add pagination, or keep them if we do :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of the Categories Manager
Changes:
Testing: only manual - I can't run the specs :(
Known issues: